koki watanabe
koki watanabe
I’m seeing the same issue on macOS 15.5 using a Python 3.12.10 venv (venv-3.12). Running `spin docs` aborts with a segmentation fault in scipy.stats.sampling.NumericalInversePolynomial. I tried `spin test -s stats...
Everything is ready now!!
Thanks for your comments! I agree that storing just pointers (or references) in the hash set sounds like a good idea—I’ll give that approach a try. I also realized I...
I’ve updated the implementation to store pointers in the unordered_set. In the original PR, I attempted to unify the implementations using a single templated unique function. However, considering the complexity...
@seberg @ngoldbaum I've addressed all comments received so far.
Thanks so much for the thorough review! This was my first PR to NumPy, and your detailed feedback really helped me bring it to completion. I'll take a look at...
Everything is ready now
Just to confirm—I’ll add a new variant parameter to sparse.csgraph.laplacian, defaulting to "default", and "use_abs" will activate the functionality implemented in this PR.
I’ve updated the PR to replace the boolean use_abs parameter with the new variant parameter
@dschult Thanks for the feedback! I've addressed the points you raised. Let me know if there's anything else you'd like adjusted.