Mateus Rodrigues
Mateus Rodrigues
Any updates on this?
@ahoppen I've updated the implementation for conditionals to use a much simpler lookahead approach
@ahoppen I've fixed minor problems with parseArgumentListElements and updated parseConditionList and atStartOfStatementBody implementations to address our conversation. I've also updated the tests and included some substructure assertions to ensure that...
> I believe your proposal includes parameter list support at least, right? That's right. The current proposal and implementation includes tuples, functions parameter/argument list and `if`, `guard` and `while` conditions....
BTW @ahoppen thank you so much for all the help and patience while reviewing this PR and sorry for all the troubles. That's my first time trying to contribute to...
> I don't see implementation/tests for functions _parameter_ list. e.g. from your proposal I think I didn't add this test case because arguments and parameters are parsed by the same...
> Parameters are parsed with `parseParameterClause()` not `parsePostfixExpressionSuffix()` :) Now that's strange because I never touched this functions but if I add your example as a test case `parsePostfixExpressionSuffix` is...
> That's... concerning (for current parser) 😅 I think `parseParameterClause`already supports trailing comma because `!self.at(.endOfFile, .rightParen)` breaks the while even if the last parameter has as trailing comma so I...
I've update https://github.com/apple/swift/pull/71975 implementation to match this PR.
I've update `atStartOfStatementBody` implementation and resolved the conflicts. I think that's it? @ahoppen @rintaro Thank you both for the review!