Mateo Gianolio

Incompatible with node > 0.12

10

This package is great, but cannot be installed on node versions after 0.12. Do you have any plans to update this to be compatible with newer versions? The javascript code...

**Notes** * Does NOT work with node.js 12 (?) * Works with node.js 13

Support SoftAP mode

8

We currently do not have a device to test SoftAP provisioning with so any help appreciated!

Unit tests

1

It's difficult to unit test this as practically all code needs a real device to test with. Suggestions on methodology are welcome.

They implement the security check in the example app after connecting (https://github.com/espressif/esp-idf-provisioning-android/blob/master/app/src/main/java/com/espressif/ui/activities/AddDeviceActivity.java#L699-L753) but not in the library itself. So if you try to connect to an ESP device configured with...

If we rewrite ESPDevice to a factory class returning subclasses based on input params for `transport` and `security`, we can get cleaner method calls to `connect` (instead of passing `null`...