node-memcpy icon indicating copy to clipboard operation
node-memcpy copied to clipboard

Incompatible with node > 0.12

Open mateogianolio opened this issue 9 years ago • 10 comments

This package is great, but cannot be installed on node versions after 0.12. Do you have any plans to update this to be compatible with newer versions?

The javascript code is still valid on later versions, but since the build fails the module isn't added and therefore cannot be used.

mateogianolio avatar Oct 20 '15 17:10 mateogianolio

+1

phil-legitmix avatar Mar 10 '16 21:03 phil-legitmix

I'm working on updating the code to create a new pull request in an effort to make this module compatible with higher versions of Node. If the need arises, I will create a new npm package for this. I will also create an issue on gcloud to provide better support.

eagerestwolf avatar Jul 12 '16 22:07 eagerestwolf

Ok, this is going to take longer than expected. I actually have to rewrite the entire thing...it would appear nan now uses a newer syntax for C++, which is causing a lot of errors

eagerestwolf avatar Jul 12 '16 23:07 eagerestwolf

Ok, so I managed to fix the issues...but it is still failing 1 test, and it no longer works on versions of node <4. YOLO...anyhow, I cannot figure out why this test is failing...I have tried and tried and tried, but it's not doing what I want it to.

eagerestwolf avatar Aug 02 '16 14:08 eagerestwolf

Hello sethmurphy18, thanks for your changes :) Any chance of having it merged to the main memcpy repository?

BenoitHanotte avatar Apr 02 '17 10:04 BenoitHanotte

What is the latest version of node with which this is compatible? It fails to build on 6.10.2 (latest LTS release) and 7.8.0 (latest unstable release). I'm using a very stock 16.04 version of Ubuntu.

daggilli avatar Apr 06 '17 16:04 daggilli

0.12 so waay back.

mateogianolio avatar Apr 06 '17 16:04 mateogianolio

Note that since node 4.0.0, Buffers are Uint8Arrays backed by an ArrayBuffer anyway. This change effectively renders this module useless (at least for my initial use case), hence it hasn't been updated anymore.

dcodeIO avatar Apr 06 '17 17:04 dcodeIO

Oh well, never mind. I am as careful as possible to write no-copy buffer code when I can but sometimes it's unavoidable that data needs copying so there's still a use case I believe. Wish I had time to investigate further.

daggilli avatar Apr 07 '17 00:04 daggilli