Matej Gera

Results 114 comments of Matej Gera

The check for `Go build for different platform` on the PR is not getting out of `Expected` state, but the job actually ran succesfully (https://github.com/thanos-io/thanos/actions/runs/3195252383/jobs/5215692706). I'm not sure if this...

Hey @oded-dd, we're now on a [newer `minio-go`](https://github.com/thanos-io/objstore/blob/main/go.mod) version, so unless there are more extra steps needs to enable IMDSv2, this should be considered resolved.

Thanks for the confirmation @oded-dd, in that case I'm closing this.

Do we have any updates here @yeya24?

Yeah, hit this today as well, this should not be a big issue to fix

Yeah this is becoming increasingly an issue for us as well, where replays on some replicas for some tenants can take ten(s) of minutes. I guess it has been like...

I have now added possibility to use snapshot on shutdown in https://github.com/thanos-io/thanos/pull/5836, also the change @yeya24 mentions already landed in Thanos, so we should see improvements. Please try either or...

Hey @phillebaba, I revisited this and I think you're totally right, we are unable to properly determine error cause if there is a multi-error within a multi-error. This can happen,...

I also added benchmark for realloc version with `DeepCopy` it seems to be slightly slower than current version: ``` go test -benchmem -benchtime=10s -run=^$ -tags integration -bench ^BenchmarkTransformWithAndWithoutCopy fix-data-race-receive-writer-labels goos:...