thanos
thanos copied to clipboard
thanos-io
IMDSv2 support requires minio-go/v7 v7.0.13
Is your proposal related to a problem?
Current Thanos does not support AWS IMDSv2
Describe the solution you'd like
Upgrade the minio-go library to IMDSv2 supported version i.e v7.0.11+
Describe alternatives you've considered
Only way.
Additional context
Would be fantastic if it can be added asap.
Believe this is more complicated that just incrementing the minio version; since currently thanos is running a fork; from another issue.
👋 I'd love to see IMDSv2 support added to Thanos. I cloned the upstream and found it merged cleanly into the fork.
Is it possible to bump the fork as a quick way to get IMDSv2 support?
We all want it fast, but we will hit new issues if we don't move back to upstream and provide upstream fixes when needed.
The fork was basically a hotfix for a serious issue. This is, with all due respect, a feature request.
The clean path is to move back to upstream if possible. We can't start to maintain a fork of minio (: As we are also an OSS project, this is maybe a nice incentive to get help on this issue.
P.s. I'm not strictly saying that this is the path we must walk, but from a projects point of view the most healthy path IMO.
We are on the same page, there are ways to kill fork. Let's discuss it here: https://github.com/thanos-io/thanos/issues/5393
I updated fork, so we can start using IMDSv2 unless there is anything to do on our side to enable it.
See: https://github.com/thanos-io/thanos/pull/5474
@bwplotka Did you figure out if this just works now, or if there's remaining work to be done in Thanos to enable it?
Hey @oded-dd, we're now on a newer minio-go version, so unless there are more extra steps needs to enable IMDSv2, this should be considered resolved.
