Results 63 comments of Serhii Shliakhov

Not sure I understand the issue. Have you tried this? ``` Artisan::call('scout:import', [ 'searchable' => ['Book', 'Ticket'] ])

It's not a problem to remove `final` keyword but first lets find a good reason for it. The more api we open the harder refactoring can be later

Yeah the same command not possible as I remember. I thought about it and didn't find any reason to fight with it. I think new name is fine. But of...

I'm not big fan of macroable but maybe. What if we rename signature of import command and then call it from a command with import:scout signature(just a wrapper to use...

Thanks for yours review. As understand you're too busy now so if anyone want to implement the wrapper feel free to send pr.

I think we should configure engine here https://github.com/laravel/scout/blob/c145b4dd752ccdda7855344981dd1815ee0ae746/src/Builder.php#L314

Or you can extend builder in your app to ``` $model::search($query, function (Client $client, Search $body) use ($model, $field) { $highlight = new Highlight(); $highlight->addField($field); $body->addHighlight($highlight); return $client->search(['index' => $model->searchableAs(),...

Now perfect api for me looks like(no callback at all) ``` $model::search(new Query($term))->engine(new Engine(new ResultsFactory))->paginate(100); ``` Or now we can do like this ``` $raw = $model::search($query, function (Client $client,...

Or without changing `laravel/scout` api `$model::search($term)->query(new ResultsFactory)->paginate(100);` We should't choose [ how to map](https://github.com/matchish/laravel-scout-elasticsearch/blob/f2cf4d79fc8dfbe0e712dc57fd45a5bc43bd416e/src/Engines/ElasticSearchEngine.php#L110) results in the engine if we have `queryCallback` just send to the callback raw results then...