Serhii Shliakhov
Serhii Shliakhov
For someone who wants to help. First of all we need fail test. We have to upload the mail view to test application https://github.com/matchish/laravel-scout-elasticsearch/tree/master/tests/laravel/app Then we have to register the...
Hey) Could you create a test that reproduce the issue? I think it can be possible when we do update, and before we didn't do an import by using the...
https://stackoverflow.com/questions/54690343/elasticsearch-when-inserting-a-record-to-index-i-dont-want-to-create-an-index What do you think if we add this parameter as default settings to a cluster? It will prevent the bug in default configuration. There is another case when user...
Cool, a pull requests for that would being highly appreciated. :tada: https://github.com/matchish/laravel-scout-elasticsearch/blob/master/CONTRIBUTING. Here I set a driver for tests. You have to override it in your tests https://github.com/matchish/laravel-scout-elasticsearch/blob/dfcc90d3356275e512ef509dcdc3d0e92df71e22/tests/TestCase.php#L35
I believe the solution is to not register commands if driver isn't `Matchish\ScoutElasticSearch\Engines\ElasticSearchEngine` https://github.com/matchish/laravel-scout-elasticsearch/blob/dfcc90d3356275e512ef509dcdc3d0e92df71e22/src/ScoutElasticSearchServiceProvider.php#L52
Does it solve the issue if you add this package to dev section of composer file?Then you can install without dev dependencies on production
Also you can try to make providers deffered https://laravel.com/docs/7.x/providers#deferred-providers But I'm not sure about drawbacks.
@booni3 Actually you are right at some point, it's better when a package works after `composer install` without config. In case of Elasticsearch I can't imagine application without customizing config...
Now config from vendor will be merged by default if you publish `ElasticSearchServiceProvider`. Did you publish elasticsearch provider?
I think maybe it's better to autoload it also by default. And if someone wants to override it, he can do it app service provider.