Matan Lurey

Results 470 comments of Matan Lurey

You mean change the implementation of `flutter devices --machine`?

There is an alternative that is not deprecated and coming in the next stable, it's [`toARGB32()`](https://main-api.flutter.dev/flutter/dart-ui/Color/toARGB32.html); our apologies for it not making it into the 3.27 release; we do guarantee...

Right, it's not about sharing code or not (we should merge our X implementations of SkiaGoldClient once we merge repos, but it's orthogonal to not breaking the current implementation).

> I don't understand why the hardcoded values would not be good after the monorepo merge if we are fine with not sharing code? They are a url and a...

Sg so I'll change this to "remember to change the hard-coded value".

I am not sure exactly what will happen. I am guessing we are not going to turn on engine CI in the same PR we move everything over?

I looked into this, and it feels like this was added in order to make the tests pass - again defer to the iOS folks to be certain.

As-per discussion on https://github.com/flutter/flutter/pull/157393 I'll re-assign this to @loic-sharma and land a short-term fix instead.