Matan Lurey

Results 487 comments of Matan Lurey

Nice, that seems like a reasonable way to do some testing. Thanks Kevin!

@andrewkolos has been OOO for a few days, I'll have @jonahwilliams spot check this.

@jonahwilliams has an interesting idea on renaming and reusing this flag as a bundle of features versus a 1-off. Will post a new GH issue and go from there.

I am merging this after renaming the flag `--implicit-pubspec-resolution` as discussed (https://github.com/flutter/flutter/issues/157819).

@gaaclarke Still seeing this issue?

@gaaclarke Let's close this issue then so we aren't tracking things we don't think are important to fix or address.

Removed from queue due to tree outage (https://github.com/flutter/flutter/issues/160702).

Alright good to go. You might want to merge the fix forward first.

> I think I want to change the way we handle this a bit. Can we close this PR in favor of #169395? Sure, works for me. I'm hoping to...

@yjbanov: There are some legitimate test failures I need to work through, but WDUT of this approach?