Hidayat Khan

Results 12 comments of Hidayat Khan

I have added implementation for two functions and created a PR. I was wondering about how to write some of the harder WASM implementations. I tried but I couldn't find...

> Looks good, I think you're on the right track here. > > Just make sure you don't throw away your test case generator code accidentally! You might want to...

> > sse4.2: added the implementation for mm_cmpestra > > I have created this PR from a new branch as old branch's commit history became very messy. > > The...

I think I did some mistake while generating test or there is some bug in my code, so some test functions are failing, I will try to fix it now.

I think everything is fine now, couple of jobs are failing in travis ci, but I think it is not related to PR, I shall quickly implement all the tests....

> Also, you should probably tweak your test case generation code to occasionally generate a 0 in the inputs. Hitting the end of the string is a common case, there...

> It looks like the native versions generate a different result for some tests. I am concerned with this, what can be the reason for this? Is there anything wrong...

> It works. We've already masked off the irrelevant bits when you set `polarity` at the beginning of the function, so all we need to do for the first check...

> > Also, you should probably tweak your test case generation code to occasionally generate a 0 in the inputs. Hitting the end of the string is a common case,...

I have spotted more errors, I realised that setting a bit of a number is different from assigning it. I will complete this with all tests soon. I have also...