Masaya Suzuki

Results 56 comments of Masaya Suzuki

@rwxdash @suleymanbarman @serkan-ozal Please review it.

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review >To assign a reviewer to a pull request, you will need write access to the repository. I do not have permission to assign reviewers...

I tested using https://github.com/massongit/action-hadolint/pull/3. In this PR, hadolint returned output like below: https://github.com/massongit/action-hadolint/actions/runs/12743374300/job/35513359427#step:3:39 ``` message:"Avoid additional packages by specifying `--no-install-recommends`" location:{path:"testdata/Dockerfile" range:{start:{line:3 column:1}}} severity:INFO source:{name:"hadolint" url:"https://github.com/hadolint/hadolint"} code:{value:"DL3015" url:"https://github.com/hadolint/hadolint/wiki/DL3015"} message:"Pin versions...

https://github.com/massongit/action-hadolint/actions/runs/12744513322/job/35516568361 ( https://github.com/massongit/action-hadolint/pull/3/commits/89e935aed66ff6fa5a980175ca66712461419985 ) I remove `reporter`. However, CI do not fail.

I think it is possible to enable hadolint's CI as a required stage by setting only `runner / hadolint (github-pr-review)` to required without `reviewdog / hadolint` required. For example: https://github.com/massongit/action-hadolint/pull/4.

II think that I do not understand your conditions. Therefore, I recommend that you do the following: 1. You fork this repository 2. You create a PR that reproduces the...

https://docs.github.com/en/rest/pulls/comments?apiVersion=2022-11-28#list-review-comments-on-a-pull-request--fine-grained-access-tokens >The fine-grained token must have the following permission set: >* "Pull requests" repository permissions (read) How about adding permission to read pull requests using the following code? ```yml permissions:...

>また、段階的に == を === に変更するのが良さそう。 多くのプログラミング言語では `==` を使うはずなので、他の言語への取り掛かりという意味では現行ママの方が良いような気がします。 また、もし、 `===` に変える場合は `==` を意図せず使わないよう、 `==` を文法エラーとする方が良いかと思います (プログラミングに慣れているプログラマーでもNode.jsを普段使いしていないと間違えやすいポイントなので)。