workflow-telemetry-action icon indicating copy to clipboard operation
workflow-telemetry-action copied to clipboard

Change the axis color of workflow metrics to match GitHub theme setting

Open massongit opened this issue 1 year ago • 7 comments

Fix https://github.com/catchpoint/workflow-telemetry-action/issues/42

I fix this action to automatically change the axis color of workflow metrics to match GitHub theme setting.

FYI: https://docs.github.com/en/get-started/writing-on-github/getting-started-with-writing-and-formatting-on-github/basic-writing-and-formatting-syntax#specifying-the-theme-an-image-is-shown-to

Screenshots

https://github.com/massongit/workflow-telemetry-action/actions/runs/13598930026?pr=1 ( https://github.com/massongit/workflow-telemetry-action/pull/1 )

Dark mode

スクリーンショット 2025-03-01 9 32 30

Light mode

スクリーンショット 2025-03-01 9 33 01

massongit avatar May 22 '24 03:05 massongit

@rwxdash @suleymanbarman Please review it.

massongit avatar May 28 '24 03:05 massongit

@rwxdash @suleymanbarman @serkan-ozal Please review it.

massongit avatar Oct 08 '24 23:10 massongit

Maybe you can assign them as reviewers to notify them

BourgoisMickael avatar Feb 28 '25 23:02 BourgoisMickael

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/requesting-a-pull-request-review

To assign a reviewer to a pull request, you will need write access to the repository.

I do not have permission to assign reviewers...

massongit avatar Feb 28 '25 23:02 massongit

Can you include a screenshot to show the graphs works well in dark mode

BourgoisMickael avatar Feb 28 '25 23:02 BourgoisMickael

I add screenshots to PR description.

massongit avatar Mar 01 '25 00:03 massongit

I can confirm it looks the same as the screenshot on GitHub mobile on iOS (from the test PR linked)

echoix avatar Mar 01 '25 00:03 echoix