Masakazu Kitajo comments

Results 158 comments of


                                            Masakazu Kitajo

Reduce the default size of max header sizes

[approve ci autest]

Proposition for removing the global suppression `-Wno-stringop-overflow` from the build

The proposed code looks good, and I'm +1 on removing the suppression. I'd go with `ink_strlcat` because use of strncat isn't common in ATS codebase. Would you make a Pull...

Proposition for removing the global suppression `-Wno-stringop-overflow` from the build

A Pull Request against `master` would be great. We'll take care of other branches.

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

Other functions around this function use `ink_strlcpy`. Doing a different thing just for this case doesn't look like a right way. Can the other functions have similar issue and need...

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

If you think the clean fix is different from this change, why don't you leave a note? How could I know this is a compromise? Also, I don't think we...

Don't assume LogAccess::m_client_req_unmapped_url_canon_str is null terminated.

I said 9.**1**.x.

Update XPACK.cc - initialize the table after allocation to avoid bad access

Let's say the fuzzer doesn't find anything at the moment. How do we know index numbers are checked appropriately at every place, after we make changes? Also, the zeros set...

Update XPACK.cc - initialize the table after allocation to avoid bad access

> if you forget to initialize an entry before using it accidentally, it will be less harmful. Until the buffer is overwritten. An argument would be that we should zero-clear...

AddressSanitizer: heap-use-after-free HQSession::main_event_handler

This is same as #11113, and I thought #11145 fixes it but it didn't. This is so weird.

Fix a bug in parsing chunked messages

[approve ci autest]