Masakazu Kitajo
Masakazu Kitajo
It's not 10.0 blocker, but I'd like to merge this before it gets conflicts.
There's no blockers, right?
@masaori335 I can't tell if it's related without seeing the actual error log, but this issue is going to be closed by #11415. Create a new issue if you still...
[approve ci autest]
I updated the documentation.
Strange error on FreeBSD build ``` /usr/bin/c++ -pthread CMakeFiles/test_vars.dir/print_funcs.cc.o CMakeFiles/test_vars.dir/vars_test.cc.o -o test_vars -Wl,-rpath,/usr/home/jenkins/workspace/Github_Builds/freebsd/src/build/lib/swoc libesitest.a ../common/libesi-common.a ../lib/libesicore.a ../fetcher/libfetcher.a ../common/libesi-common.a /usr/lib/libz.so ../../../lib/swoc/libswoc-1.5.12.so ld: error: vars_test.cc:(function std::__1::vector::__recommend(unsigned long) const: .text._ZNKSt3__16vectorIPN5Catch16TestCaseTracking8ITrackerENS_9allocatorIS4_EEE11__recommendEm+0x3D): relocation R_X86_64_PLT32 out...
[approve ci freebsd]
It looks like the both `read` functions are only used to read whole data in a buffer. Forwarding the `l` argument is a valid change, but I'd remove the `l`...
Ah, I missed the use in `Handler::data`. Then just from the `TSIOBuffer` version.
> I just believe that warning suppression is bad because the warnings sometimes point to real issues/bugs and we should use any help from the compiler and the other tools...