Michael Ashton

Results 6 comments of Michael Ashton

Support new Naranja validation algorithm

Ok. I now see that this is just Luhn written in a roundabout way. That explains why the algorithm is labeled `Luhn 10` 😅. I'm going to keep this PR...

Instrument batching in opentelemetry_broadway

Hi folks, pardon me if just opening a PR out of the blue is not the done thing here. I didn't see any guidance otherwise. I'd love to contribute to...

`--format=sarif` still outputs summary with using `mix credo diff`

> The big question is, what should that output look like? Only list the new issues? @rrrene, good point. Tricky question. I think the SARIF way to do this is...

{:replace_all_except, [:other_field]} with `conflict_target` may raise ArgumentError when :other_field is ONLY other field

Thanks! What if I want to grow my `TestSchema` with new fields, but always want to `replace_all_except: [:id]`? One would need to remember to add all the new fields.

{:replace_all_except, [:other_field]} with `conflict_target` may raise ArgumentError when :other_field is ONLY other field

That would mean there are two recommended ways to support this requirement (if it is intended to be supported): `replace: [:other_field], conflict_target: :other_field` Once your schema grows beyond `:id` and...

{:replace_all_except, [:other_field]} with `conflict_target` may raise ArgumentError when :other_field is ONLY other field

Not sure I grok it. Like this? ```elixir EctoTest.Repo.insert_all(__MODULE__, query, conflict_target: :other_field, discard_changed: [:id] ) ``` where: ```elixir {:discard_changed, fields} -> to_remove = fields # don't remove anything else ```