MashIro comments

Results 6 comments of


                                            MashIro

fix the concurrent problem of handlers in ResponsePromise

ok , I would conside this better way tomorrow, and commit a new version

fix the concurrent problem of handlers in ResponsePromise

> > > maybe we just need a CopyOnWriteList instead of the lock/unlock I think only using CopyOnWriteList may not solve the problem. In this case we won't have any...

fix the concurrent problem of handlers in ResponsePromise

@lburgazzoli Hello , I'd thought a lot ,but didn't finger out anyway better than lock/unlock . ReentrantLock is an cas operation , also used in CopyOnWriteList and I use it...

may it cause a concurrent problem while using ResponsePromise.addListene method?

Of course ,I'm glad to do that

may it cause a concurrent problem while using ResponsePromise.addListene method?

> > > yep it could, do you mind sending a pr to fix it ? done with a simple lock

Fix a NPE in FileSystemImpl & Add a test case.

@vietj Hello , I'm sorry that I closed #4199 because of my mis-operation of git to rebase. Here I forked & committed again , would you like to merge this...