Marcial Gaißert

Results 20 comments of Marcial Gaißert

It would be good if we had a solution to this before merging #119 and #122, which both would require an updated version of this binary.

Adding escaping here would work: https://github.com/effekt-lang/effekt/blob/5fa89a2cfd03f4a9f899a8f242df33ad51e4e6b5/effekt/shared/src/main/scala/effekt/generator/js/JavaScript.scala#L74

But we would probably want to do this in a more principled way than replacing only some characters?

Alternatively, we could just whitelist allowed characters for file and module names.

If we want arbitrary file names to work, also with weird combinations, we would need to encode the characters used somehow (eg `_??` for characer `\x??`). Replacing everything "special" with...

> > Alternatively, we could just whitelist allowed characters for file and module names. > > Are you asking to change allowed names in source / Effekt? Module and file...

Ok, should `hello-world`, `hello_world` and `hello/world` be different? Then we can't just replace all of them with `_`. (Although this admittedly is a corner case.)

I also now added correctly ordering the methods/operations (in the order they are declared), and multiple operations for effects onto this PR.

For some reason, `fibonacci.effekt` works on my machine but fails in the CI.