Kunal Marwaha
Kunal Marwaha
I'm reopening this because I think I've addressed Joe's main issue -- attributing credit properly. All of my commits have been replaced with Joe's name and email.
I looked at the test that's failing. It's reporting that the ionposition isn't correct. But it's actually correct, up to a scaling (I think it's off by a factor of...
@jbroz11 it looks like there are decent ways to do this https://stackoverflow.com/questions/3887736/keep-git-history-when-splitting-a-file
more on submodules here: https://docs.julialang.org/en/v1/manual/modules/
Goal after today: Make non-adaptive time-stepping the default
Two things from Joe: * specify spectral density * list of values (under the hood, turn it into a continuous function) #72
joe requests this happens before 1.0
I think the best thing to do is add this list to https://docs.ionsim.org/ .
We also want to add an arbitrary vector of timevalues as input.
duplicate of #70