Martín Triay

Results 103 comments of Martín Triay

This is currently on our [project roadmap](https://github.com/orgs/OpenZeppelin/projects/15), just that it's prioritized as "Low". This means we will tackle it whenever we finish higher priority issues, or we reprioritize based on...

This is currently on our [project roadmap](https://github.com/orgs/OpenZeppelin/projects/15), just that it's prioritized as "Low". This means we will tackle it whenever we finish higher priority issues, or we reprioritize based on...

Hey @koloz193! Do you think you will be able to finish this one off or should we pick it up? Thanks :)

@koloz193 kind ping (:

Amazing! Now there's only the merge conflicts left.

Agree with this. I don't think this flag makes much sense cc/@bbrandtom. If the idea is to protect users from mis-deploying (not sure if that's a good idea either), then...

> All right so I guess problem solved! So I guess you testing with a local clone of the OZ repo? > > @martriay @andrew-fleming do you think OZ could...

> @martriay why do you think the flag is problematic? Why an 'account' directive will be better? Because you can't just compile all the contracts on a project, and there's...

One possible implementation can be found in [argent's account contract](https://github.com/argentlabs/argent-contracts-starknet/blob/0ce073f808f1a46fb956eadbdbe378e08c6355d1/contracts/ArgentAccount.cairo). It performs each check separately, which is basically the same logic but for a privileged signer. ``` validate_signer_signature(message_hash, signatures, signatures_len,...