cairo-contracts icon indicating copy to clipboard operation
cairo-contracts copied to clipboard

Add ERC20Burnable preset

Open koloz193 opened this issue 3 years ago • 12 comments

Created an erc20 burnable preset from the mocked file and removed the mock since it's no longer needed.

Fixes #237

Depends on:

  • #240
  • #244

koloz193 avatar Apr 01 '22 15:04 koloz193

Hey @koloz193, thank you for submitting this PR! I know you're aware that we're considering some changes to the library (#267 and you mentioned in your comment^). Once we get this straightened out, we'll be able to review :)

andrew-fleming avatar Apr 19 '22 00:04 andrew-fleming

@andrew-fleming makes sense. i ended up doing a fresh refactor based on the current state of main

koloz193 avatar May 03 '22 13:05 koloz193

@koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare

andrew-fleming avatar May 04 '22 06:05 andrew-fleming

@koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare

yup, once i saw like 10 different files i quickly decided against trying to attempt the rebase

koloz193 avatar May 04 '22 11:05 koloz193

@koloz193 Ownable is merged! I appreciate your patience, sir 🙏 at your leisure, would you mind updating your branch?

andrew-fleming avatar May 24 '22 04:05 andrew-fleming

awesome! will merge in main and clean it up!

koloz193 avatar May 24 '22 18:05 koloz193

@andrew-fleming @martriay any update on this 😄

koloz193 avatar Jul 13 '22 15:07 koloz193

This is currently on our project roadmap, just that it's prioritized as "Low". This means we will tackle it whenever we finish higher priority issues, or we reprioritize based on new information. Sorry it's taking so long 🙇.

martriay avatar Jul 13 '22 17:07 martriay

Hey @koloz193! Do you think you will be able to finish this one off or should we pick it up? Thanks :)

martriay avatar Aug 05 '22 15:08 martriay

@martriay yup I'll wrap it up this weekend!

koloz193 avatar Aug 05 '22 15:08 koloz193

@koloz193 kind ping (:

martriay avatar Aug 15 '22 08:08 martriay

@martriay just pushed the changes, sorry for the delay but ran the tests and it looks good

koloz193 avatar Aug 16 '22 14:08 koloz193

Amazing! Now there's only the merge conflicts left.

martriay avatar Aug 18 '22 17:08 martriay

Amazing! Now there's only the merge conflicts left.

not anymore 😄

koloz193 avatar Aug 22 '22 14:08 koloz193