cairo-contracts
cairo-contracts copied to clipboard
Add ERC20Burnable preset
Created an erc20 burnable preset from the mocked file and removed the mock since it's no longer needed.
Fixes #237
Depends on:
- #240
- #244
Hey @koloz193, thank you for submitting this PR! I know you're aware that we're considering some changes to the library (#267 and you mentioned in your comment^). Once we get this straightened out, we'll be able to review :)
@andrew-fleming makes sense. i ended up doing a fresh refactor based on the current state of main
@koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare
@koloz193 ahh yeah, the rebasing conflicts must have looked like a nightmare
yup, once i saw like 10 different files i quickly decided against trying to attempt the rebase
@koloz193 Ownable is merged! I appreciate your patience, sir 🙏 at your leisure, would you mind updating your branch?
awesome! will merge in main and clean it up!
@andrew-fleming @martriay any update on this 😄
This is currently on our project roadmap, just that it's prioritized as "Low". This means we will tackle it whenever we finish higher priority issues, or we reprioritize based on new information. Sorry it's taking so long 🙇.
Hey @koloz193! Do you think you will be able to finish this one off or should we pick it up? Thanks :)
@martriay yup I'll wrap it up this weekend!
@koloz193 kind ping (:
@martriay just pushed the changes, sorry for the delay but ran the tests and it looks good
Amazing! Now there's only the merge conflicts left.
Amazing! Now there's only the merge conflicts left.
not anymore 😄