Martin Trapp

Results 21 comments of Martin Trapp

Hi @sarah11918, thank you for pinging! As @fryuni said, it would be good to have the event's properties and there purpose defined in the docs. Especially because they are already...

> Is this also something we need to factor in to new view transitions docs? Once we make that "official" it would fit well to the description of the `swap`...

Hi @kevin8181, I'm sorry that `astro-vtbot` is the source of trouble here! Thank you very much, @HiDeoo, for the initial analyzes and opening an issue. I will look into that...

Haha, I didn't take it that way either! I'm happy when we can help fix bugs. And it's even more motivating when you know that people are using the things...

Here is my preliminary analysis: I assumed that Starlight made the styling of active sidebar entries solely dependent on `aria-current="page"`. But this is not the case. As HiDeoo already wrote,...

Of course, I would also be happy if Starlight would not set the `.outline` class at all, keep the variant class on all entries and overrides the current page badge...

@hippotastic can't someone ;-) add Expressive Code to GitHub, PLEASE!

> Of course, I would also be happy if Starlight would not set the `.outline` class at all, keep the variant class on all entries and overrides the current page...

Saw that, thank you! Love #1530, @kevinzunigacuellar already did all the work. That PR would reestablish my earlier assumption that sidebar current entry styling only depends on `aria-current='page'` 😀

Hi @HiDeoo! I closed https://github.com/martrapp/astro-vtbot/issues/77 as the badges indeed work now as expected, see https://events-3bg.pages.dev/jotter/history-of-changes/. Updating to the current Starlight version was the only change required.