Martín Volpe

Results 56 issues of Martín Volpe

### Expected Behavior PR #10268 introduced a vulnerability and will get reverted on CR10. ### Current Behavior Not deployed. More info: Governance.sol:dequeueProposalIfReady(uint) (L1258-1294) PR #10268 and PR #10324 introduce a...

stale

### Expected Behavior Some methods, like upvote, should be able to be called with the same id they have at the time of executing. ### Current Behavior Some methods in...

stale

### Expected Behavior If the commission of a group is 100%, then validators get zero. There should not be an event emitted. ### Current Behavior It is issuing events with...

stale

### Expected Behavior SortedOracles contracts are upgradable modifying contracts in this repo. ### Current Behavior Our tooling is currently [ignoring SortedOracles](https://github.com/celo-org/celo-monorepo/blob/master/packages/protocol/lib/compatibility/ignored-contracts-v9.ts#L9) in the check-versions script[1]. The reason for this is...

stale

- [x] Add modifier so that only vm can call - [x] Add modifier so that it can only be called on Celo (by checking Celo Registry address has bytecode)...

evm

### Component Forge, Anvil ### Have you ensured that all of these are up to date? - [x] Foundry - [x] Foundryup ### What version of Foundry are you on?...

T-bug

Currently the devchain is created with latest contracts in the commit it is built. The devtooling team ready wants to start working on celi/contractkit changes that require an L2 enabled....