Martín Volpe

Results 56 issues of Martín Volpe

Functions should support: * ` handle(address tokenAddress)` * `handleAll()` * `distribute(address tokenAddress)` * `distributeAll()` As described in the CIP: https://github.com/celo-org/celo-proposals/blob/master/CIPs/cip-0052.md ```[tasklist] ### Tasks - [x] Expose functions in contract kit...

stale

### Expected Behavior The tooling should check all the packages against all old packages ### Current Behavior Just checks old versions of 0.5: https://github.com/celo-org/celo-monorepo/pull/10437/files#r1279498765

stale

Test in files should not be skipped: https://github.com/celo-org/celo-monorepo/blob/1ddf637efe2dfecb3659a2f81cda9f26e849611b/packages/protocol/test/common/migration.ts#L36 https://github.com/celo-org/celo-monorepo/blob/1ddf637efe2dfecb3659a2f81cda9f26e849611b/packages/protocol/test/common/migration.ts#L48

stale

See for context: (https://github.com/celo-org/celo-monorepo/pull/10437#discussion_r1279522840

stale

### Expected Behavior Core smart contracts shouldn't be redefined many times. ### Current Behavior They are defined in multiple places for multiple proposes, for example: * https://github.com/celo-org/celo-monorepo/blob/master/packages/protocol/migrations_ts/27_governance.ts#L88

stale

### Expected Behavior Contracts to be deployed should include what package they belong to. ### Current Behavior It supports a fallback with package 0.8, which may not be the right...

stale

### Expected Behavior Tooling is aware core contracts are mapped 1:1 with proxies with a common name. Follow up: This pattern is repeated in many places in the codebase, with...

protocol
stale