martintmk
martintmk
Hey @iliar-turdushev > As I understand, SetRequestMessage will be useful for the Hedging handler when a user wants to replace the request object with a custom one, right? Yup, they...
> The implementation is blocked because of the following issue in Polly [App-vNext/Polly#2299](https://github.com/App-vNext/Polly/issues/2299). The issue doesn't allow us to make `requestMessage` argument of `SetRequestMessage` nullable. > > ```cs > public...
This code reproduces the issue: ``` csharp using System; using System.Net.Http; using System.Net.Security; using Microsoft.Extensions.DependencyInjection; using Microsoft.Extensions.Http.Resilience; var services = new ServiceCollection(); var clientBuilder = services .AddHttpClient("ClientR9") .ConfigurePrimaryHttpMessageHandler(() => new...
How about checking against `ResilienceContext.CancellationToken`? If `ResilienceContext.CancellationToken` is not cancelled and we receive `TaskCanceledException` with that layout we know that this cancellation came from `SocketsHttpHandler` when establishing connection.
@lquerel We are quite interested in advancing this forward. What would you say is the biggest blocker right now towards adopting and generating type-safe metrics in `opentelemetry-semantic-conventions`? Additionally, would similar...
@iliar-turdushev , Great investigation! > services.ConfigureHttpClientDefaults(x => x x.AddStandardResilienceHandler().SelectPipelineByAuthority()); This helps slightly in a way that at least multiple clients with different authorities won't share the same circuit breaker. (which...
> If we go with this approach to _decorate_ all Polly exceptions (that derives from the `ExecutionRejectedException`) then that we would generate consistent behavior across the strategies. BUT for those...
> > How about we treat the `UpdateTelemetrySource` as an pub-internal API (albeit hidden, so it can be used in `Polly.RateLimiting`). We will add the `TelemetrySource` property to all our...
> I'm not against the idea of the pub-ternal API. I think if we go down that route it's better to do the minimal amount and do more later if...
> > > I'm not against the idea of the pub-ternal API. I think if we go down that route it's better to do the minimal amount and do more...