martintmk

The easy enhancement is to improve the `HttpClientResiliencePredicates` to also detect gRPC calls and handle retriable status codes: https://github.com/dotnet/extensions/blob/80abb8ddf7a2454930ae2378b121f044fe3df848/src/Libraries/Microsoft.Extensions.Http.Resilience/Polly/HttpClientResiliencePredicates.cs#L46 This should make both retry and circuit breaker strategy work for...

> Failure is communicated in grpc-status trailer. The trailer is available only after the response body is finished reading, is that correct? I am wondering how we can ensure that...

LGTM, great job! How about to update our docs too in follow-up?

@martincostello is this ok to merge?

Hey @martincostello I think making this work will be more difficult, even not possible. The thing is that the predicates are more complex than `Predicate` and assigning it to `RetryOptions.ShouldHandle`...

I am thinking, how about we add a `Outcome Outcome` field to existing `BreakDurationGeneratorArguments`?

The proposal looks good to be. The only thing I suggest is too actually use the following class as a source property: https://github.com/App-vNext/Polly/blob/main/src/Polly.Core/Telemetry/ResilienceTelemetrySource.cs Basically, to uniquely identify strategy you also...

@martincostello I am thinking that this might be even good default behavior for retry strategy? Individual attempts are warnings while the final one is error?

> Why is it better to use Polly's timeout policy implementation over built in HttpClient timeout? Few reasons why this is beneficial: - When Polly strategy is triggered, the resilience...

> Given you are the main expert on this, are you expecting any feedback from anyone else @martintmk or is this ready for review? I believe this is ready for...