Martin Schaef

Results 15 comments of Martin Schaef

Uploading SARIF files started failing for me about 24 hours ago. [Here](https://github.com/martinschaef/apilearner/runs/4178096197?check_suite_focus=true) is an example of the failure. [Here](https://github.com/martinschaef/apilearner/runs/4154824313?check_suite_focus=true) and [here](https://github.com/martinschaef/apilearner/runs/4154824313?check_suite_focus=true) are examples of the container uploading the SARIF file...

Answering my own question: I need the permissions block, otherwise the OpenID connect fails and it has to look like this: ``` permissions: id-token: write contents: write # This is...

I can unblock myself by adding -Xep:ParameterName:OFF as suggested in: https://github.com/google/error-prone/issues/780#issuecomment-451590154

I'll have to look into that... I remember that I just gave up on this before the deadline... it's not actually unsound on the reasoning side, it's the transformation that...

I don't think it's a bug and the test passes currently. There might be situations where we cannot remove all traps. This usually happens when the compiler (or soot) introduces...

Sure, can do ... lines 252-256 in which file? Did you know that github has a real 'review request' feature? Let's use that instead :)

Ah ... this is a trickier one. There is already a flag to do what you suggested in [line 334](https://github.com/jayhorn/jayhorn/blob/f3560bcf0b406628bb581466a5de5db42bcad87f/soottocfg/src/main/java/soottocfg/soot/transformers/ExceptionTransformer.java#L334). The question is what do we need to check on...

Makes sense ... I'd say let's focus on getting that parser for the IL running. Did you receive [my gist with the bnfc grammar](https://gist.github.com/martinschaef/85e24ed102bbcd757135043754b7245c)? Once we have that parser, we...

I downgraded that because technically, it's not a bug. Its just under-specified.

I'll look into this. Are u available for a chat before the call with Philipp?