Martin Pengelly-Phillips

Results 123 comments of Martin Pengelly-Phillips

Thanks for the kind words. The logic you see in dnd-kit is similar to what I had before (see the example code at the top of this issue). However, I...

Hey, I've been thinking about this recently as part of the refactor / update. I'm considering a "transformers" approach, but thinking about where to apply it. I'm interested in your...

This is now possible in [0.7.0](https://github.com/thisbeyond/solid-dnd/releases/tag/0.7.0) by applying a custom transformer. See example in release notes or on https://solid-dnd.com

Yes. I had some support for that, but removed it to revisit the problem more holistically (see #32).

Hey. This sounds like a generally useful thing that we should add into the default sensor (ignore right clicks). Feel free to submit a PR. Alternatively I'll add this in...

In latest version I don't believe the behaviour happens anymore (due to improvements in the sensor logic), though there is no special handling for right clicks. Closing, but feel free...

@timothyallan I can't reproduce that 🤔 What OS and browser are you using? How are you dismissing the context menu? ![solid-dnd-right-click](https://user-images.githubusercontent.com/214338/199381968-df26465b-7c46-4d07-8064-c4ceebee3400.gif)

Hmm. I'm testing on Windows so that's a difference. I'm happy to implement a check for right mouse button in the activation logic, but I'd like to understand what is...

That is odd indeed - logically the drag should not become stuck because on pointerup the listeners are removed and all drags stopped. The only way that could occur is...

Thanks! That does look like the contextmenu is intercepting the onpointerup we rely on. I've released [0.7.3](https://github.com/thisbeyond/solid-dnd/releases/tag/0.7.3) now that should fix it - please give it a go.