Martin Pengelly-Phillips comments

Results 123 comments of


                                            Martin Pengelly-Phillips

Customisable guess logic

Sure - will try and work up some unit tests. In the meantime I'll expand on the example to help clarify requirements: Given a custom type ``` python def bool_type(string):...

Solid JSX HTMLElement types do not allow `on:event` props

As a related note - I encounter the issue of delegated vs non-delegated event listeners when creating libraries that use ref/use: callbacks for convenience. In the callback I setup listeners...

Solid JSX HTMLElement types do not allow `on:event` props

That sounds interesting to me (and I think being able to decide on the library author side whether to delegate or not would be useful). Let me know if there...

<input value={undefined}> shows string "undefined"

I just encountered this after updating an older project. Curious when this behaviour changed as it didn't seem to happen before?

required, additionalProperties, propertyNames, dependentRequired and any other validators that reference property names need a way to indicate the erroring names in ValidationErrors

Doesn't the property technically exist for `.schema_path`? As an error occurs for each missing property, it seems to me like that would be an appropriate place. So it would be...

required, additionalProperties, propertyNames, dependentRequired and any other validators that reference property names need a way to indicate the erroring names in ValidationErrors

Ah, yes - I forgot it was an array not an object there. So then the logic in my system would be to retrieve the associated schema from `.schema` and...

required, additionalProperties, propertyNames, dependentRequired and any other validators that reference property names need a way to indicate the erroring names in ValidationErrors

Another idea would be that `validator_value` becomes the single value being evaluated (`validator_value == 'a'`). Note sure if that breaks conventions though. Happy with any solution that makes it easy...

required, additionalProperties, propertyNames, dependentRequired and any other validators that reference property names need a way to indicate the erroring names in ValidationErrors

I realise I actually meant the other way round, but, yeah, it doesn't seem to work. Have opened a new issue to avoid diverting this one (#120).

required, additionalProperties, propertyNames, dependentRequired and any other validators that reference property names need a way to indicate the erroring names in ValidationErrors

For reference, I currently use the following workaround: ``` python # Custom validators def _required(validator, required, instance, schema): '''Validate 'required' properties.''' if not validator.is_type(instance, 'object'): return for index, requirement in...

PicklingError using live_server fixture on Windows

Hi @vitalk - thanks for the quick response. I've tried that branch now and it fixes the previous error. However, a new error is given now: ``` request = @pytest.fixture(autouse=True)...