Martin Fleck

Results 33 comments of Martin Fleck

@msujew Thank you very much for your fast and detailed review! I added another commit to it so you can see the changes but I can also squash them if...

@colin-grant-work Thank you very much for your review! I pushed it as a separate commit so you can see the changes at a glance. If need be, I can squash...

@vince-fugnitto @alvsan09 Thank you very much for your input! I tested it a few times with `Launch Electron Backend & Frontend` and for me the debug sessions do seem to...

@colin-grant-work Could you please have a look if you believe the reported issues are connected to this PR or some other setup issue that is only revealed through this PR?...

@alvsan09 Thank you for your in-depth analysis! I agree that starting another Theia instance from Electron seems to cause a problem with the plugin host. When I start the debug...

I just checked and the problem with 'Attach to Plugin Host' also happens when I start all three launch configurations manually. I therefore created a new bug for it here:...

@alvsan09 Oh wow, great catch, thank you! Seems like I removed something when updating the current configuration and so changed properties were not correctly applied.

@alvsan09 Oh wow, you are right! I am very sorry for missing that! Seems like the typeguards were not good enough to detect a dynamic configuration vs a regular configuration....

@alvsan09 I updated the search for the current configuration again, I think now all cases should be covered. Thank you very much for taking the time!

@alvsan09 Thank you again for your feedback! 1. I fixed the naming issue, there was indeed a change as we now use a different serialization so the name was not...