Marten Seemann

Results 924 comments of Marten Seemann

Added some more tests. This should be ready to merge once CI passes.

The problem is that opening a new stream is a purely local operation. If you do it on a connection that has been sitting around for a while, opening the...

Revisiting this issue now that I'm tackling client GOAWAY handling (#5083), and of course @rs was right. At the very least, we have to reset the request body, similar to...

I'm a bit confused about `GetBody` now: If we decide to only retry non-idempotent requests, the check for `GetBody` is moot in most cases: GET and HEAD requests usually don't...

The standard library's could be the following: If a `http.Request` sets `GetBody`, it implicitly opts into the request being retried. After all, that's the entire purpose of `GetBody` in the...

Ok, so the `GetBody` was a red herring. This entire code path is located behind the [`canRetryError`](https://cs.opensource.google/go/x/net/+/refs/tags/v0.40.0:http2/transport.go;l=740), which makes sure that only a certain type of error is retried. In...

This is only the neqo qlog, where's the quic-go qlog?

In somewhat recent Caddy versions you should be able to just set the QLOGDIR env: https://github.com/caddyserver/caddy/pull/6581. Could you rerun your test using the most recent Caddy version? v2.8.4 uses quic-go...

Your analysis is incorrect. The packet was dropped due to a connection ID mismatch: Also note the different packet sizes.