Marten Seemann
Marten Seemann
#4705 tracks the issue. This PR claims to fix the issue, and it does, in a certain sense of "fixing". The problem is that the connection counter goes up and...
> Okay. I just want to make sure there's no bad blood here, because I'm hearing frustration from @WeidiDeng about his attempts to collaborate. I think we all have the...
I see, you already made the change. I reopened the PR. Sorry again! Have you tested if this new version actually fixes the problem? Would be great to get confirmation...
> It was tested by a user here [caddyserver/caddy#6643 (comment)](https://github.com/caddyserver/caddy/issues/6643#issuecomment-2423758401) Is that the version with or without the atomic? Because if there is a race condition in the connection counting...
> I noticed another problem with my current implementation though. If caddy is idle, during http3 shutdown, h3 shutdown will block here. > > https://github.com/quic-go/quic-go/blob/6af2b1a478211ebf98125b996e13f6d994e6ba3e/http3/server.go#L746 > > This is because...
Thank you @WeidiDeng for the fix, and thanks to everyone for testing! > Speaking of goaway frame client-side handling, @marten-seemann do you still want a pr to be opened? Yes,...
I have no idea what's wrong with stupid @codecov (again!). This PR literally doesn't change test coverage at all, let alone by hundreds of lines, as a 0.56% change would...
I might be blissfully ignorant regarding the edge cases of JSON serialization, but in my mind, NLJSON is trivially simple to define: ``` Every line in and of itself is...
> > Simple example: count how many times a particular event happened: grep | wc. We're just creating unnecessary frustration if simple stuff like this doesn't work. > > It...
It seems to work on CI: https://interop.seemann.io/