Vladimir Kochnev

Results 54 comments of Vladimir Kochnev

> @dblock expressed his concern that this does not follow the same logic as redefining a method The new conception of exposures is that they don't simulate _method definitions_ —...

...When comparing Her to ActiveRecord it's the one of the important features Her lacks. And since creating connections is done by Her itself there is no other way to setup...

You can read more about all this stuff in the updated [README](https://github.com/marshall-lee/her/blob/connection_pool/README.md)

@hubert I don't think so. Using a connection pool is optional so installing a connection_pool gem is also optional. Her should not require it to work — https://github.com/marshall-lee/her/commit/5288afd8576250fe611c58c165af494b4acc4972#diff-6b1740b8978bf165426acae9d1c17138R1

`add_runtime_dependency` is an alias to `add_dependency` :smiley:

I made it a development dependency only for running connection pool-related specs.

Maybe it is worth to add a connection_pool as a dependency and use it every time. Even if there's only one connection, having a pool will automatically solve thread safety...

@hubert > 1) could you create a new connection_pool_spec done! > 2) i know Net::HTTP:Persistent maintains it's own connection pool. have you tested the code with this adapter to make...