Marlon Basten
Marlon Basten
@arnebr As my PR won't get merged, there's still a need for German state holidays. 😕 Feel free to add this to your PR! I don't think that this package...
Thanks for the effort @Nielsvanpach! 😊 I think this solution is also fine for adding regions. It can get messy though as some countries have a lot of regions. There...
@Nielsvanpach I saw that someone approved the workflows for this PR 😄. I saw that PHPStan was failing so I fixed that. Even if this doesn't get merged, maybe something...
> How many levels should be added? > > In Spain we have national (country), by autonomous community (region), province (state) and city. > > Is this a common case...
@Nielsvanpach Thanks for running the tests again! I genuinely do now know why this one test is failing. When looking at the logs everything seems to be alright, but the...
@eusonlito That would be an option too. But what about if you want to get the holidays for a city including the nationwide holidays? In Germany for example we have...
@eusonlito I could do that. But I don't want to put any more time into this PR because I already got told that my solution will not be merged 😅...
@MeiKatz Smart and easy solution indeed! That would work well for Germany. I have an initial thought about that tho: How would you get only the holidays that apply to...
Closing this PR now due to lack of communication.