Markus Thömmes comments

Results 155 comments of


                                            Markus Thömmes

minScale treatment races reachability check

Just reproduced the behavior of the labeler I described: Running the MinScale test and adding a 30s sleep to the labeler caused it to never see the first revision and...

minScale treatment races reachability check

@jwcesign it's not, nope!

Support startupProbe in webhook

I believe we want to look at consuming this field from Knative itself rather than relying on readinessProbe as much as we do today. Once we have a minimum K8s...

[gRPC/http2 auto-detect] Flakiness and potential connection leak

Ha! Writing the HTTP2 preface and then closing the response **seems** to show the desired result.

[gRPC/http2 auto-detect] Flakiness and potential connection leak

Not working on this /unassign

Autoscaler tests should be runnable under chaos

/remove-lifecycle stale

Autoscaling in Knative and in the Cluster

Sounds fair enough. This should fix #9432

Autoscaling in Knative and in the Cluster

To be clear, I don't like a special cased "let's wait some longer" either. If we can get a signal from the deployment that stuff eventually moved forward though, I...

Autoscaling in Knative and in the Cluster

That's sort of what I was getting at: If the deployment is able to recover any of those failure cases, why wouldn't we? I guess we're saying the same things...

targetBurstCapacity does not behave correctly when there is more than one activator pod

Thanks for opening this! We should: 1. Check if our subsetting is behaving correctly (I assume it is) 2. Discuss if we want to allow for a `minActivators` of `1`...