Markus Thömmes

Results 157 comments of Markus Thömmes

Okay, we clarified offline: In my comment about switching to workqueue based stuff I meant metric **scraping**, not probing. Sorry for the confusion.

Yep, just know that this might be a somewhat bigger refactor of the current scraper code. I think we first need to agree that we actually want work-pooling here as...

We might want to think about the guarding measures we want to take first maybe. That makes accepting/denying this a no-brainer imo. How do we want to measure success/failure or...

Hm, but wouldn't we want to show that implementing this generates an advantage over the existing way of doing things (which doesn't require hand-tuning either). We might want to produce...

Yeah let's write a Golang benchmark (I don't think an E2E one is necessary) and see if we can find a break even point between just spawning new goroutines and...

Is this relevant in https://github.com/knative/serving/issues/9544 too?

I agree for the ways to go at this for Category A and B. As for Category C: Are K8s Events not sufficient for this currently? There should already be...

I guess I meant to point out, that it's possible for a revision to never be touched by the labeler. For example if you create a Route + Config and...

Right, so this list might miss Revisions, which then are in `RouteState = Pending` (which we would take as a signal to not scale down for minScale purposes) and they'd...