Markus Hintersteiner

Results 313 comments of Markus Hintersteiner

Let's start small and use the existing API 29+ callbacks in the first iteration. And it could be a good chance to refactor our `ActivityLifecycleIntegration`.

@ganadist thanks for creating this issue, we'll provided some feedback in the PR! 🚀

Let's make this configurable: * by default do it only for release builds * if configured, you can define all required buildTypes (`~sentry { sourceContext { enabled: true|false, buildTypes: []}}`)

Hey @RationalRank, thanks for the additional feedback! You could always run the upload task (e.g. `./gradlew :app:sentryUploadSourceBundleRelease`) manually to upload sources.

Hey @nandorholozsnyak thanks for opening up this issue and contributing a PR: https://github.com/getsentry/sentry-java/pull/3199 If you need some help on the PR itself, kindly let us know in the comments.

@G00fY2 , thanks for reporting! Yes, this stems [from here](https://github.com/getsentry/sentry-java/blob/9e1abf3a01a46390e2bbc7bed9fa9b563b6f8e79/sentry/src/main/java/io/sentry/SpotlightIntegration.java#L87), although it's worth noting this URL is not being used unless spotlight is explicitly enabled via `SentryOptions`. We'll discuss this...

The underlying issue seems to be that we want to package the `BuildConfig`, before it's even created. Let's have a closer look and check if maybe even should exclude the...

Let's also keep our `SpanFrameMetricsCollector` in mind, as it's `onSpanFinished` callback requires the finish date to be already set.

Given that we have a mixed behavior for txn/spans, let's consider this broken and fix it. Let's apply this to both Spans and Transactions.

Thanks for reaching out @rolandsarosy, let me try to reproduce this on our end.