Move the onFinishCallback before the span is finished

Open stefanosiano opened this issue 1 year ago • 2 comments

https://github.com/getsentry/sentry-java/pull/3219#discussion_r1500496194

Feb 26 '24 17:02 stefanosiano

Let's also keep our SpanFrameMetricsCollector in mind, as it's onSpanFinished callback requires the finish date to be already set.

Feb 27 '24 08:02 markushi

Given that we have a mixed behavior for txn/spans, let's consider this broken and fix it. Let's apply this to both Spans and Transactions.

Feb 28 '24 14:02 markushi