markus983
markus983
Hi @peternewman , thanks for your help! > From a quick look at the code, it does indeed appear that the break and MAB get skipped if we're not in...
> Excellent thanks. So do you see the failed granularity message during high load and then it recovers afterwards? Yes, with these changes the plugin was always able to recover...
@kripton & @peternewman thanks for your feedback! I took care of the changes and hopefully the linter will be satisfied now as well.
@peternewman I fixed these lint issues. Hopefully, these were the last. Is there a way to trigger the lint check myself?
Hi, it's been a while, just wanting to make sure that this PR won't be forgotten. Is there anything that is still blocking a merge?
I took care of the lint issues and the PR is now targeting the branch 0.10
> I'm not sure if this was my error or yours, but there's one outstanding lint issue remaining if you wouldn't mind. It should be fixed now. > Have you...
@peternewman Thanks for the info, I fixed the calculation of the frame time and it should honor, the boundaries now. I tested it as well, and the UART plugin still...
I tweaked the code as you've suggested - thanks for the feedback! Hopefully, this PR can be included in 0.10.9. Unfortunately, it looks like I've somehow messed up the git...
> Do you want to open a PR against this which I think is what you actually intend to merge now?: > https://github.com/OpenLightingProject/ola/compare/0.10...markus983:ola:0.10 Yeah, that would make it easier. The...