Markus Bergholz

Results 147 comments of Markus Bergholz

@duderamos do you have some time to fix the integration test as @jillr suggested?

Not related to this pr, but according to the yaml documentation of this module, `input` and `input_path` must become `mutually_exclusive=(['input', 'input_path'])` in the argument specs.

> Not related to this pr, but according to the yaml documentation of this module, `input` and `input_path` must become `mutually_exclusive=(['input', 'input_path'])` in the argument specs. ..because https://github.com/ansible-collections/community.aws/pull/354/files#diff-3a2f223edc4e34ea28b9859827a830844d92a8cd97f1300a2d16b1703a083bc8R358 this does...

`platform_version: "1.4.0"` is also missing in the integration test. without platform version, it fails. Also the `group` seems to be necessary.

I've tested it here locally with both op versions (2.7.1 and 1.12.4). Both works for me. This is a very valuable PR. @samdoran can you add a changelog fragment please?

> We can note that boto3 already support this option (at least since `v1.14.2` i'm working with) : > > ```python > import boto3 > client = boto3.client('ecs') > client.update_service(cluster='cluster_name',...

Ah sorry. I thought the entire parameter was missing. So yes, imo the internally logic must just be fixed, so that `force_new_deployment: yes` works also on existing service without the...

In some cases it is reversable when you use a simple custom python filter that uses just `snake_dict_to_camel_dict`. But aws has so many exceptions in their keys all over their...

The issue is, that the status is still "attaching", so this is failing https://github.com/ansible-collections/amazon.aws/blob/main/plugins/modules/ec2_vol.py#L519 in the idempotent test task. two possible fixes 1. the module must wait until `status` becomes...

I run the tests locally. I _guess_ it all passes. But at the end, the test still return exit code 1. No idea why. ``` .... localhost : ok=16 changed=6...