Mark Thomas

Results 274 comments of Mark Thomas

OK. My reading of RFC 8441 and RFC 9220 is that in the same way the initial upgrade request would require authentication in HTTP/1.1, the CONNECT request in HTTP/2 and...

See Servlet issue https://github.com/jakartaee/servlet/issues/546 and associated PR https://github.com/jakartaee/servlet/pull/547

Fixed via https://github.com/jakartaee/servlet/issues/546 and https://github.com/jakartaee/servlet/pull/547

I think there is consensus that the WebSocket needs an API that; - allows a ping to be sent every X seconds - fails the connection if the corresponding pong...

I don't recall any requests for Tomcat to implement any sort of regular ping mechanism. On that basis, I have proposed a PR that clarifies the responsibilities for ping/pong but...

Filters and interceptors are essentially what extensions were designed for but there hasn't been as much take up of those as expected. See #340 for some further discussion on that....

This PR should use NetMaskSet as well.

The proposed change removes the explanatory comments. They need to be kept so future maintainers can easily understand why the test is skipped for OS/400.

Updated to commons-parent to pick up new templates with the IRC reference removed and regenerated the generated files.

I'm expecting to fill in the blanks over the next 24 hours or so.