Mark Stosberg

icon indicating a website link https://mark.stosberg.com/

icon company @RideAmigosCorp icon location Bloomington, Indiana, USA icon location Building a better commute with @RideAmigosCorp and Node.js. Personal repos are at https://gitlab.com/markstos

Results 532 comments of Mark Stosberg
trafficstars

load config file based on custom env param

@Kenhuey Typo? Here you wrote "NODE-CONFIG_ENV" not "NODE_CONFIG_ENV"

The _substituteVars function throws an illegal key type for substitution map if it encounters and array while mapping the variables in custom-environment-variables.json

@lorenwest should we even try to support arrays in `custom-environment-variables.json`? It seems tricky since one config can override an array of a previous config, changing the location of particular values...

The _substituteVars function throws an illegal key type for substitution map if it encounters and array while mapping the variables in custom-environment-variables.json

He's trying to express "for the configuration key "messagehub", the first value of that array should be set to the environment variable named "API_KEY", using `custom-environment-variables.json`. I'm just not sure...

The _substituteVars function throws an illegal key type for substitution map if it encounters and array while mapping the variables in custom-environment-variables.json

@ljestrada We do document that arrays are merged by replacement: https://github.com/lorenwest/node-config/wiki/Configuration-Files#arrays-are-merged-by-replacement

The _substituteVars function throws an illegal key type for substitution map if it encounters and array while mapping the variables in custom-environment-variables.json

@ljestrada You are welcome to improve the wiki.

The _substituteVars function throws an illegal key type for substitution map if it encounters and array while mapping the variables in custom-environment-variables.json

@ashishblood Did you also implement tests which highlight how the changed behavior works? Did check out #569 ? It proposes addressing mapping environment variables using a templating engine. It includes...

Fix for #309: Interpret SUPPRESS_NO_CONFIG_WARNING more broadly

This could be expanded to also fix #644-- warn or throw in the case when the host is unfortunately named "default".

Fix for #309: Interpret SUPPRESS_NO_CONFIG_WARNING more broadly

@JonaC22 Still waiting for a volunteer to rebase and resolve the conflicts here and squash it into a single commit. It could be you.

Nestjs build perfomance issue when using node-config

FYI @flodaniel

Nestjs build perfomance issue when using node-config

The maintainers are not using `node-config` in combination with Nest.js or Next.js. If are you are impacted user, consider looking into the root cause.