Mark Stosberg

Results 532 comments of Mark Stosberg
trafficstars

When using the `--debug=true` option, I noticed this: ``` 2014-05-26T00:20:44 [DEBUG] CookieJar - Created but will not store cookies (use option '--cookies-file=' to enable persisten cookie storage) ``` It's still...

Since setting the cookies is optional, I'm in favor of this addition. (I'm a co-user, not a maintainer). I reviewed the pull request. My only addition would more documentation to...

phantomFlags is now supported. What do you think about having this turned on when `DEBUG=phantom-render-stream` is set? It sort of a preference about whether one big debugging flag is preferred,...

@davisford You may be interested in this patch, since its similar to one you developed increase the amount of diagnostic output available.

What is your `maxRenders` value set to? Recycling the workers periodically should stabilize the memory usage if its in the phantom process. The default value is 20.

I ran into memory growth today after the tool was used over 100 times today, growing a PhantomJS process to 6.7 Megs. It turns out that maxRender is only documented...

The leakage should be re-tested with Phantom 2. Having a default maxRender value of `20` vs `500` may still be a better default value.

@davisford Did you end up looking at atom.io's solution for PDF generation? FYI to those on the thread, there's a fork of this project at https://github.com/SamMorrowDrums/phantom-render-stream that is currently trying...

@davisford Do you recall any tips to make it Nightmare.js for those who might follow in your footsteps to make it less painful? One thing I notice is that Nightmare.js...