Mark Story

Results 653 comments of Mark Story

The only thing I can think of is that github doesn't automatically expose org secrets to external pull requests.

Storing gzip data in yaml files feels gross. Removing the `content-encoding` header and storing the response body as str/bytes seems more human-friendly to me.

How would you expect to define and use the captured groups? Perhaps an example of what you want to do but cannot do easily today.

Could you share an example of the code you're trying to make work?

> At the very least, I believe it should be documented that and why add_callback doesn't return a response. There isn't a good reason other than it didn't do it...

> Is there any plans to support async http io? There aren't any current plans to add async io support. We're not using asyncio at sentry, so it hasn't been...

> should we just import it from requests then ? :+1: to importing the types if we can.

Currently responses will read and buffer any IO streams that are passed to it, which is why you're not able to reproduce the scenario you're looking to emulate. I don't...

> Users would have to make these changes: > > - Change CollectionInterface type declarations to Collection > - Get the inner iterator before calling printer() on the TreeIterator The...

Do you also happen to have the same jira workspace connected to another sentry org?