Mark Story

Results 653 comments of Mark Story

Should we detect that the provided path is a project root and do the right thing for users? If we can find a src/, tests/, config/ directories we could add...

Closing as one of the fixes was merged.

Not all of these are doable with rector, but I can update the 40 rules for the ones we can automatically update.

Thanks for letting us know about that @TomasVotruba I'll circle back on this and figure out how to do the other changes.

> Is this expected behaviour? No, tests should pass. What version of MySQL are you running tests against?

This is likely caused by join() clauses being separate from contain() clauses. The reason for this separation is that not all contain() operations generate joins. #17184 is somewhat related.

> but shouldn't it generate a bunch of left joins because it's a chain of belongsTo associations? Sure, in your situation that is true, but that isn't always the case...

DebugKit doesn't know about connection roles yet, we'd need to improve how debugkit collects queries to make that possible.

> Is there a way to have an option to disable this syntax for tables with triggers, something like: ->save($data, ['output_inserted' => false]); If we don't include the output clause,...

> I think this could be accompanied by a second query like SELECT SCOPE_IDENTITY(); to retrieve the ID. Ok, I don't frequently work with SQLServer, but if you have a...