Mark Story

Results 653 comments of Mark Story

Thanks for putting this together. I like the idea of providing a type safe way to access request data. I'm a bit concerned with the number of methods we would...

@jozefgrencik That's an interesting approach. We had a related discussion in the core team and had another approach to consider as well: ```php namespace Cake\Utility; function toInt(?mixed $value): ?int {...

> I will create a new class with the toInt()/toBool.. functions in a separate PR, and then we will see how we proceed with this PR. Okay? Sounds great. Thank...

How can someone reproduce the problem you're having? The default value of `dropTables` parameter is `true`, so wouldn't this method not work with the default arguments?

I can take another look at this. We shouldn't have errors like this being emitted from valid parameter sets.

> Do we want to act on this regarding 4.5 or 5.0 now? We could add the coalesce to false in 4.4. The current behavior is broken so we won't...

> Maybe we could say null is that value, and you simply continue to return the response for normal flow? That would break existing behavior though. Currently returning null is...

We don't support joins/unions across databases. Database connections could be in different physical machines and there is no way for the ORM to safely abstract operations across databases.

> I'm not sure if this is expected behavior though. Why are you modifying the request `here` attribute? The `here` request attribute is an oddball backwards compatibility alias for 'base...

> I looked into the code, guess I should use getRequestTarget and withRequestTarget instead? Yes. This would be a way to get the compatibility you want.