Mark Story

Results 653 comments of Mark Story

> OK, I’ve got it running on Odin but it’s Odin only. I don’t have time right now to also make it work in Hera. I’m thinking of releasing a...

I have no context on alternative parsers for sphinx, and won't be able to support them well. You'd need to submit a pull request with some form of regression tests...

> I have the same issue when trying to actually create any kind of improved wrapper around it. Maybe instead of extending it, we could encapsulate it using the proxy...

> Downside is that the types on methods wouldnt work, if something expects a native one. Which is why we'd have a `toNative()` type method to provide compatibility with non-application...

Changing the documented return type will result in phpstan errors because the documented type and the defined type diverge. We could suppress those warning in cakephp, but I'm not sure...

> another alternative might be to render the namespace directive like class: > and then not render the NS before any class. Not all projects that document namespaced classes include...

Other return types are also missing their description text.

@getsentry/crons There are a few failing tests in these results from the monitor details endpoint. https://github.com/getsentry/sentry/blob/793c62cb6cf3f99dc8fe6d13de5945a333bf09c0/src/sentry/monitors/endpoints/base_monitor_details.py#L181-L247 This passage of code currently makes a cross database transaction. While this code behaves...

> I notice the followup item is closed already -- should that get picked up so the traceback stuff can get fixed too? There are a few more RPC methods...