Mark Story comments

Results 653 comments of


                                            Mark Story

Create a built-in CORS handler

> It could still be nice to have in case one has a need to run additional logic on either preflight or CORS requests, and the builder could potentially use...

Create a built-in CORS handler

> To be fair I don't really have a good real world example at hand, but it would allow to easily do something like: I think the example you gave...

targetForeignKey in belongsToMany doesn't have effect, defaults to target model name

What is the schema for these tables? You don't need to include all the columns enough that we can try to reproduce your issue. Also it is helpful to have...

targetForeignKey in belongsToMany doesn't have effect, defaults to target model name

I'm going to assume that the `bonuses` table looks something like ```sql CREATE TABLE `bonuses` ( id int not null primary key, name varchar(250), ... ); ``` I'll see if...

targetForeignKey in belongsToMany doesn't have effect, defaults to target model name

> no no, there is no bonuses table, table products references itself but under an alias of Bonus Ok. That wasn't clear in the initial issue report, thank you for...

targetForeignKey in belongsToMany doesn't have effect, defaults to target model name

I wasn't able to reproduce the problem, or I don't understand the problem correctly. I've attached the files I used, and the output I got from running `bin/cake bug` below...

Query::bind() does not make the count query dirty although it should

Another way to reset the query bindings is to use `$query->getValueBinder()->reset()`. Given there are a few existing ways to do this with either the ValueBinder or Query::clearResult() do we still...

Associated finds with map/reduce don't work

> Should the core allow associated results being grouped in whatever way the user wants? Yes and no. In order to stitch association data together the ORM needs to be...

4.next - Add CORS middleware

Thanks for putting this together. I think we should spend a bit more time figuring out what the developer facing interface should be before we write out how it would...

Update use of deprecated / internal phpunit classes

If we only get the class name will we have enough context to read the fixture names? We could run into problems if user land tests define `$fixtures` in the...