Mark McCluskey comments

Repositories
Issues
Comments

Results 3 comments of


                                            Mark McCluskey

Inconsistent batting_stats_range() response.

I'm getting this, too. I've been playing with different date ranges; some work but some don't. I ran: ``` from pybaseball import batting_stats_range split = "2022-05-25" data_before = batting_stats_range("2022-03-31", split)...

'max_results' parameter for fangraphs query not respected when 'month' parameter given

The Fangraphs URL when specifying month is not in the same format as when not specifying month. - When pulling 2023 non-pitcher stats for all batters, you would use: `data_raw...

'max_results' parameter for fangraphs query not respected when 'month' parameter given

I've been digging into this. When you supply the month, the following line in get_tabular_data_from_url function of HTMLTableProcessor doesn't process "query_params" as passed: `response = requests.get(self.root_url + url, params=query_params) `...