Mark Mikkelsen

Results 16 comments of Mark Mikkelsen

> @markmikkelsen do you think you could add a README.md to each dataset? > > one of them has an excellent README but the 2 others have none > >...

This pull request is nearly ready for merging. The check failures relate to the MRS filename suffices not being included in the `bids-validator`.

> There are no examples of `nuc-` or `voi-` entities. These would be helpful for validating entity ordering. I'm ignorant of how the validator works, but does it rely on...

Gotcha. Since the datasets are not real. I can just create a bunch of example of fake datasets to satisfy this.

I want to point out that most MR manufacturers don't even use the DICOM format to export/store MRS data. They use their own format. Hence why we designed the NIfTI-MRS...

Thanks, @neurolabusc—that's very helpful to know! I'm glad the manufacturers are working together to better harmonize terminology. As you know, it's been a particularly challenging issue for MRS software developers.

Coming back to this from the MRS-BEP: `B0ShimmingTechnique` `NumberReceiveCoilActiveElements` As far as I am aware, these have no equivalent DICOM tags but are very useful to the understanding of measurement...

I'm not sure why the check_links test is failing. Seems to be a URL leading to a publication, but there isn't anything wrong with the link.

> Had a quick look. I may be missing something but... > > I am wondering if there is any reason to add the matrix size as a metadata when...

> It seems that this PR for the MRS modality introduces some metadata that could be reused by several if not all the datatypes under the MRI modality. > >...